-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to real pypi #1074
switch to real pypi #1074
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @joamatab Please also uncomment line 82 so we don't upload wheels for every commit. Also change the base to branch 0.27. @klayoutmatthias uses the master for future releases.
perfect, Done! thank you Thomas, |
@joamatab can you change the target branch from master to 0.27? |
yes, see this PR |
Thanks for this PR. You don't need to change the target branch. I'll keep that master and 0.27 synchronized myself when merging. I just like to suggest one enhancement: it's Ok to use real PyPI for releases, but I actually liked having an option to deploy to test PyPI for example for providing preview releases. So my suggestion was to scan for special tags like "v*-preview" and trigger a PyPI-test deployment for those. What do you think? Matthias P.S: I hate that PyPI even in the test instance does not allow deleting releases :( |
@joamatab can you take a stab at duplicating the upload step (one for test and one for real) based on tag name? I'm on mobile for the next 4 days. You can delete a pypi wheel but can't reupload with the same version. So only the first pypi upload works. @klayoutmatthias the only silver lining is that the upload step only runs if tests are successful. |
That's perfect - I don't want to upload anything for which the tests are failing :) @joamatab Yes, you can delete a release but never use the same one again. Previously I ended up with fake ones just because I made some mistake. BTW: I got a message by @Kazzz-S who is doing the Mac releases. He is no longer able to push to his own fork:
Edit: I understand he needs to generate a new token and make sure workflow scope is enabled, right? Matthias |
okay, now it always uploads to test_pypi and also uploads to pypi for new releases let me know what you think |
Yes, you are right. I've regenerated a new token enabling the workflow scope and set it in my git client tool (SmartGit). In my case, however, I needed to follow the instructions below.
Now, I can push branches to my fork. I appreciate your help. |
No description provided.